Apply post-review cleanups from PR #1 #2

Manually merged

bryan merged 1 commit from bryan/review-cleanups into main

2026-09-10 21:44:37 +00:00

bryan commented

2026-09-10 20:05:42 +00:00

Owner

Follow-ups from the review of PR #1.

Drop the redundant sitemap filter. Prototype routes never build in production and the output test already asserts the sitemap has no prototype entries.
Remove the unused compact prop from Brand.astro and the no-op <>…</> fragments in Services.astro. Rendered HTML is unchanged.
Lower the contact textarea limit from 2500 to 1500 characters which shortens the generated mailto URL and reduces the chance of truncation in strict desktop mail clients (it does not eliminate it once the text is percent-encoded).
Use fileURLToPath / URL objects instead of URL.pathname in the brand asset script and the tests, so both work from a checkout path that contains spaces.

Not addressed here, noted for later: the production build still emits unreferenced prototype CSS and JS chunks under dist/_astro/. A dev-only dynamic import did not stop Vite from bundling them, so this is left as a known limitation.

Validation: npm test (build + 5 output tests) and npm run format:check pass.

Follow-ups from the review of [PR #1](https://git.snowboardtechie.com/bryan/thompson-codes/pulls/1). - Drop the redundant sitemap filter. Prototype routes never build in production and the output test already asserts the sitemap has no prototype entries. - Remove the unused `compact` prop from `Brand.astro` and the no-op `<>…</>` fragments in `Services.astro`. Rendered HTML is unchanged. - Lower the contact textarea limit from 2500 to 1500 characters which shortens the generated mailto URL and reduces the chance of truncation in strict desktop mail clients (it does not eliminate it once the text is percent-encoded). - Use `fileURLToPath` / URL objects instead of `URL.pathname` in the brand asset script and the tests, so both work from a checkout path that contains spaces. Not addressed here, noted for later: the production build still emits unreferenced prototype CSS and JS chunks under `dist/_astro/`. A dev-only dynamic import did not stop Vite from bundling them, so this is left as a known limitation. Validation: `npm test` (build + 5 output tests) and `npm run format:check` pass.

bryan added 1 commit

2026-09-10 20:05:42 +00:00

Apply post-review cleanups from PR #1 55fb969319

- Drop the redundant sitemap filter; prototype routes never build in production and the output test guards it.
- Remove the unused compact prop from Brand and the no-op fragments in Services.
- Lower the contact textarea limit to 1500 characters so the mailto URL stays within common client limits.
- Use fileURLToPath / URL objects instead of URL.pathname so the brand script and tests work from paths containing spaces.

bryan changed title from ~~Apply post-review cleanups from PR #1~~ to WIP: Apply post-review cleanups from PR #1

2026-09-10 20:05:55 +00:00

bryan changed title from ~~WIP: Apply post-review cleanups from PR #1~~ to Apply post-review cleanups from PR #1

2026-09-10 21:43:47 +00:00

bryan manually merged commit b170b4f3ff into main

2026-09-10 21:44:37 +00:00

bryan referenced this pull request from a commit

2026-09-10 21:44:37 +00:00

Apply post-review cleanups from PR #1 (#2)